Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 9460064: Further refactoring of declarations in the AST: (Closed)

Created:
8 years, 9 months ago by rossberg
Modified:
8 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Further refactoring of declarations in the AST: Define modules as module declarations. Separate function declarations from var declarations. R=jkummerow@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10854

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -108 lines) Patch
M src/ast.h View 5 chunks +40 lines, -7 lines 1 comment Download
M src/ast.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 3 chunks +30 lines, -22 lines 0 comments Download
M src/hydrogen.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 6 chunks +25 lines, -19 lines 0 comments Download
M src/parser.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/parser.cc View 12 chunks +40 lines, -33 lines 0 comments Download
M src/prettyprinter.cc View 2 chunks +21 lines, -17 lines 0 comments Download
M src/rewriter.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rossberg
8 years, 9 months ago (2012-02-27 13:56:08 UTC) #1
Jakob Kummerow
8 years, 9 months ago (2012-02-27 14:22:18 UTC) #2
LGTM.

https://chromiumcodereview.appspot.com/9460064/diff/1/src/ast.h
File src/ast.h (right):

https://chromiumcodereview.appspot.com/9460064/diff/1/src/ast.h#newcode513
src/ast.h:513: // At the moment there are no "const functions"'s in
JavaScript...
nit: while you're at it, please s/'s//.

Powered by Google App Engine
This is Rietveld 408576698