Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 9460059: Update break points set with partial file name after compile. (Closed)

Created:
8 years, 9 months ago by Yang
Modified:
8 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Update break points set with partial file name after compile. BUG=v8:1853 Committed: https://code.google.com/p/v8/source/detail?r=10842

Patch Set 1 #

Patch Set 2 : Added test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -2 lines) Patch
M src/debug-debugger.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-1853.js View 1 1 chunk +116 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
PTAL. The issues thread should serve as a sufficient explaination.
8 years, 9 months ago (2012-02-27 08:19:13 UTC) #1
Søren Gjesse
lgtm Perhaps this deserves a test case?
8 years, 9 months ago (2012-02-27 08:39:33 UTC) #2
Yang
I added a test as suggested. Please take another look.
8 years, 9 months ago (2012-02-27 10:38:57 UTC) #3
Søren Gjesse
8 years, 9 months ago (2012-02-27 11:02:03 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698