build/common.gypi - Issue 9460048: Use gyp names in MIDL build rules rather than VS macros

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 9460048: Use gyp names in MIDL build rules rather than VS macros (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: fix dlldata name too Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index a098a1c451fa9b7c8fa88da3c04ed0b62751a22a..fc43cf028b694a19689b29603345cbe26bdaeeb7 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2833,12 +2833,12 @@

'VCMIDLTool': {

'GenerateStublessProxies': 'true',

- 'TypeLibraryName': '$(InputName).tlb',

- 'OutputDirectory': '$(IntDir)',

- 'HeaderFileName': '$(InputName).h',

- 'DLLDataFileName': 'dlldata.c',

- 'InterfaceIdentifierFileName': '$(InputName)_i.c',

- 'ProxyFileName': '$(InputName)_p.c',

+ 'TypeLibraryName': '<(RULE_INPUT_NAME).tlb',

+ 'OutputDirectory': '<(INTERMEDIATE_DIR)',

+ 'HeaderFileName': '<(RULE_INPUT_NAME).h',

+ 'DLLDataFileName': '<(RULE_INPUT_NAME).dlldata.c',

Mark Mentovai 2012/03/30 12:54:27 This is not equivalent to what you’re replacing. I

+ 'InterfaceIdentifierFileName': '<(RULE_INPUT_NAME)_i.c',

+ 'ProxyFileName': '<(RULE_INPUT_NAME)_p.c',

'VCResourceCompilerTool': {

'Culture' : '1033',

« no previous file with comments | « no previous file | no next file » | no next file with comments »