chrome/test/data/extensions/api_test/content_scripts/extension_iframe/iframe.js - Issue 9460002: Convert app_bindings.js to the schema_generated_bindings.js infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/content_scripts/extension_iframe/iframe.js

Issue 9460002: Convert app_bindings.js to the schema_generated_bindings.js infrastructure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: make test extension ID tests pass Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/setup_bindings.js ('k') | chrome/test/data/extensions/api_test/stubs/content_script.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/content_scripts/extension_iframe/iframe.js

diff --git a/chrome/test/data/extensions/api_test/content_scripts/extension_iframe/iframe.js b/chrome/test/data/extensions/api_test/content_scripts/extension_iframe/iframe.js

index 3e37a3a4944b62b88735faecaa1c815a788260a7..572f28047d6e70af9e6b7d1067db10fe3743bd9d 100644

--- a/chrome/test/data/extensions/api_test/content_scripts/extension_iframe/iframe.js

+++ b/chrome/test/data/extensions/api_test/content_scripts/extension_iframe/iframe.js

@@ -28,11 +28,15 @@ if (chrome.storage) {

success = false;

}

-// Parts of chrome.extension and chrome.tabs (which get included because it's

-// a dependency of chrome.extension) are unavailable.

-if (!runsWithException(function() { return chrome.extension.getViews; }))

+// Ditto chrome.tabs, though it's special because it's a dependency of the

+// partially unprivileged chrome.extension.

+if (chrome.tabs) {

+ console.log('Error: chrome.tabs exists, it shouldn\'t.');

success = false;

-if (!runsWithException(function() { return chrome.tabs.create; }))

+// Parts of chrome.extension are unavailable.

+if (!runsWithException(function() { return chrome.extension.getViews; }))

success = false;

chrome.extension.sendRequest({success: success});