chrome/renderer/resources/extensions/schema_generated_bindings.js - Issue 9460002: Convert app_bindings.js to the schema_generated_bindings.js infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/schema_generated_bindings.js

Issue 9460002: Convert app_bindings.js to the schema_generated_bindings.js infrastructure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: make test extension ID tests pass Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/app_custom_bindings.js ('k') | chrome/renderer/resources/extensions/setup_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/schema_generated_bindings.js

diff --git a/chrome/renderer/resources/extensions/schema_generated_bindings.js b/chrome/renderer/resources/extensions/schema_generated_bindings.js

index ab119234c1103ff8301fec0c80a1631b08380efe..217414c0f75376b4a9b4fd024b6ff4415a854d75 100644

--- a/chrome/renderer/resources/extensions/schema_generated_bindings.js

+++ b/chrome/renderer/resources/extensions/schema_generated_bindings.js

@@ -531,6 +531,11 @@

var platform = getPlatform();

apiDefinitions.forEach(function(apiDef) {

+ // TODO(kalman): Remove this, or refactor schema_generated_bindings.js so

+ // that it isn't necessary. For now, chrome.app is entirely handwritten.

+ if (apiDef.namespace === 'app')

+ return;

if (!isSchemaNodeSupported(apiDef, platform, manifestVersion))

return;