Convert app_bindings.js to the schema_generated_bindings.js infrastructure.

chrome/renderer/resources/extensions/app_custom_bindings.js

Index: chrome/renderer/resources/extensions/app_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/app_custom_bindings.js b/chrome/renderer/resources/extensions/app_custom_bindings.js
new file mode 100644
index 0000000000000000000000000000000000000000..9cae9d4c2777764d1d39e82a77593c61f1276092
--- /dev/null
+++ b/chrome/renderer/resources/extensions/app_custom_bindings.js
@@ -0,0 +1,52 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Custom bindings for the app API.
+
+var appNatives = requireNative('app');
+var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
+
+chrome.app = {
+  getIsInstalled: appNatives.GetIsInstalled,
+  install: appNatives.Install,
+  getDetails: appNatives.GetDetails,
+  getDetailsForFrame: appNatives.GetDetailsForFrame
+};

[not at google - send to devlin, 2012/03/20 03:32:13]

So basically the same as how it was earlier.

Just not as weirdly written.

+
+// Tricky; "getIsInstalled" is actually exposed as the getter "isInstalled",
+// but we don't have a way to express this in the schema JSON (nor is it
+// worth it for this one special case).
+//
+// So, define it manually, and let the getIsInstalled function act as its
+// documentation.
+chrome.app.__defineGetter__('isInstalled', appNatives.GetIsInstalled);
+
+// Called by app_bindings.cc.
+chromeHidden.app = {
+  onGetAppNotifyChannelResponse: function(channelId, error, callbackId) {
+    if (callbackId) {
+      callbacks[callbackId](channelId, error);
+      delete callbacks[callbackId];
+    }
+  }
+};
+
+// appNotification stuff.
+//
+// TODO(kalman): move this stuff to its own custom bindings.
+// It will be bit tricky since I'll need to look into why there are
+// permissions defined for app notifications, yet this always sets it up?
+var callbacks = {};
+var nextCallbackId = 1;
+
+chrome.appNotifications = {
+  getChannel: function getChannel(clientId, callback) {
+    var callbackId = 0;
+    if (callback) {
+      callbackId = nextCallbackId++;
+      callbacks[callbackId] = callback;
+    }
+    appNatives.GetAppNotifyChannel(clientId, callbackId);
+  }
+};