chrome/renderer/resource_bundle_source_map.cc - Issue 9460002: Convert app_bindings.js to the schema_generated_bindings.js infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resource_bundle_source_map.cc

Issue 9460002: Convert app_bindings.js to the schema_generated_bindings.js infrastructure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reabse Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/schema_generated_bindings.cc ('K') | « chrome/renderer/renderer_resources.grd ('k') | chrome/renderer/resources/extensions/app.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resource_bundle_source_map.cc

diff --git a/chrome/renderer/resource_bundle_source_map.cc b/chrome/renderer/resource_bundle_source_map.cc

index 2c06b7b318adfcee1ffaa8b70dabbe4fe7d73a89..5a4258204790d8485bd0183389115c36f4ed6f30 100644

--- a/chrome/renderer/resource_bundle_source_map.cc

+++ b/chrome/renderer/resource_bundle_source_map.cc

@@ -28,7 +28,7 @@ v8::Handle<v8::Value> ResourceBundleSourceMap::GetSource(

}

bool ResourceBundleSourceMap::Contains(const std::string& name) {

- return resource_id_map_.count(name) > 0;

+ return !!resource_id_map_.count(name);

}

v8::Handle<v8::String> ResourceBundleSourceMap::ConvertString(