Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: webkit/appcache/appcache_quota_client.cc

Issue 9456036: Work around CancelableCompletionCallback threading restrictions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_quota_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_quota_client.cc
===================================================================
--- webkit/appcache/appcache_quota_client.cc (revision 123798)
+++ webkit/appcache/appcache_quota_client.cc (working copy)
@@ -34,10 +34,7 @@
namespace appcache {
AppCacheQuotaClient::AppCacheQuotaClient(AppCacheService* service)
- : ALLOW_THIS_IN_INITIALIZER_LIST(service_delete_callback_(
- base::Bind(&AppCacheQuotaClient::DidDeleteAppCachesForOrigin,
- base::Unretained(this)))),
- service_(service),
+ : service_(service),
appcache_is_ready_(false),
quota_manager_is_destroyed_(false) {
}
@@ -56,7 +53,7 @@
DeletePendingRequests();
if (!current_delete_request_callback_.is_null()) {
current_delete_request_callback_.Reset();
- service_delete_callback_.Cancel();
+ GetServiceDeleteCallback()->Cancel();
}
quota_manager_is_destroyed_ = true;
@@ -139,7 +136,7 @@
}
service_->DeleteAppCachesForOrigin(
- origin, service_delete_callback_.callback());
+ origin, GetServiceDeleteCallback()->callback());
}
void AppCacheQuotaClient::DidDeleteAppCachesForOrigin(int rv) {
@@ -210,6 +207,19 @@
return service_->storage()->usage_map();
}
+net::CancelableCompletionCallback*
+AppCacheQuotaClient::GetServiceDeleteCallback() {
+ // Lazily created due to CancelableCompletionCallback's threading
+ // restrictions, there is no way to detach from the thread created on.
+ if (!service_delete_callback_.get()) {
+ service_delete_callback_.reset(
+ new net::CancelableCompletionCallback(
+ base::Bind(&AppCacheQuotaClient::DidDeleteAppCachesForOrigin,
+ base::Unretained(this))));
+ }
+ return service_delete_callback_.get();
+}
+
void AppCacheQuotaClient::NotifyAppCacheReady() {
appcache_is_ready_ = true;
ProcessPendingRequests();
@@ -226,7 +236,7 @@
if (!current_delete_request_callback_.is_null()) {
current_delete_request_callback_.Run(quota::kQuotaErrorAbort);
current_delete_request_callback_.Reset();
- service_delete_callback_.Cancel();
+ GetServiceDeleteCallback()->Cancel();
}
if (quota_manager_is_destroyed_)
« no previous file with comments | « webkit/appcache/appcache_quota_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698