chrome/browser/ui/toolbar/wrench_menu_model.cc - Issue 9456031: Remove PSS::ShowLoginDialog() and obsolete IDC_SYNC_BOOKMARKS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.cc

Issue 9456031: Remove PSS::ShowLoginDialog() and obsolete IDC_SYNC_BOOKMARKS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review feedback. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/wrench_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.cc b/chrome/browser/ui/toolbar/wrench_menu_model.cc

index da9c743c51bd3235aa91df540b2cf4131b55116a..3edb4864a92d017285f096d2fd5f920c01275249 100644

--- a/chrome/browser/ui/toolbar/wrench_menu_model.cc

+++ b/chrome/browser/ui/toolbar/wrench_menu_model.cc

@@ -230,7 +230,6 @@ bool WrenchMenuModel::IsItemForCommandIdDynamic(int command_id) const {

#if defined(OS_MACOSX)

command_id == IDC_FULLSCREEN ||

#endif

- command_id == IDC_SYNC_BOOKMARKS ||

command_id == IDC_VIEW_BACKGROUND_PAGES ||

command_id == IDC_UPGRADE_DIALOG ||

command_id == IDC_SHOW_SYNC_SETUP;

@@ -238,8 +237,6 @@ bool WrenchMenuModel::IsItemForCommandIdDynamic(int command_id) const {

string16 WrenchMenuModel::GetLabelForCommandId(int command_id) const {

switch (command_id) {

- case IDC_SYNC_BOOKMARKS:

- return GetSyncMenuLabel();

case IDC_ZOOM_PERCENT_DISPLAY:

return zoom_label_;

#if defined(OS_MACOSX)