Remove PSS::ShowLoginDialog() and obsolete IDC_SYNC_BOOKMARKS.

chrome/browser/sync/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service.h"
 
 #include <cstddef>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 955 matching lines @@
       break;
     case browser_sync::DISABLE_SYNC_ON_CLIENT:
       OnStopSyncingPermanently();
       break;
     default:
       NOTREACHED();
   }
   NotifyObservers();
 }
 
-void ProfileSyncService::ShowLoginDialog() {
-  // TODO(atwilson): Remove this API and have the callers directly call
-  // LoginUIService.
-  LoginUIServiceFactory::GetForProfile(profile_)->ShowLoginUI();
-}
-
 void ProfileSyncService::ShowErrorUI() {
   if (WizardIsVisible()) {
     wizard_.Focus();
     return;
   }
 
   // Figure out what kind of error we've encountered. There are only 3 kinds:
   // 1) auth error.
   // 2) server-initiated error
   // 3) passphrase error
   // Any other errors (such as unrecoverable error) should be handled by the UI
   // itself and should not result in a call to ShowErrorUI.
   if (last_auth_error_.state() != AuthError::NONE) {
-    ShowLoginDialog();
+    LoginUIServiceFactory::GetForProfile(profile_)->ShowLoginUI();
   } else if (ShouldShowActionOnUI(last_actionable_error_)) {
     ShowSyncSetup(chrome::kPersonalOptionsSubPage);
   } else {
     // We should only get here for passphrase error.
     DCHECK(IsPassphraseRequired());
     ShowSyncSetupWithWizard(SyncSetupWizard::ENTER_PASSPHRASE);
   }
 }
 
 void ProfileSyncService::ShowConfigure(bool sync_everything) {
@@ skipping 660 matching lines @@
   void* place = service;
   service->~ProfileSyncService();
   service = new(place) ProfileSyncService(
       new ProfileSyncComponentsFactoryImpl(profile,
                                            CommandLine::ForCurrentProcess()),
       profile,
       signin,
       behavior);
   DCHECK(service) << "Could not create new ProfileSyncService.";
 }