Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2218)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

Issue 9456019: Add GTK interface for installing bundles of extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm
index 445fc60ece0e9e845f97304374d6d774707a8875..0b2c330f0590f033ff20cfa9fb3ad712920826f3 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -83,9 +83,7 @@ void AppendRatingStarsShim(const SkBitmap* skiaImage, void* data) {
- (id)initWithParentWindow:(NSWindow*)window
profile:(Profile*)profile
- extension:(const Extension*)extension
delegate:(ExtensionInstallUI::Delegate*)delegate
- icon:(SkBitmap*)icon
prompt:(const ExtensionInstallUI::Prompt&)prompt {
NSString* nibpath = nil;
@@ -109,9 +107,7 @@ void AppendRatingStarsShim(const SkBitmap* skiaImage, void* data) {
if ((self = [super initWithWindowNibPath:nibpath owner:self])) {
parentWindow_ = window;
profile_ = profile;
- icon_ = *icon;
delegate_ = delegate;
- extension_ = extension;
prompt_.reset(new ExtensionInstallUI::Prompt(prompt));
}
return self;
@@ -126,8 +122,8 @@ void AppendRatingStarsShim(const SkBitmap* skiaImage, void* data) {
}
- (IBAction)storeLinkClicked:(id)sender {
- GURL store_url(
- extension_urls::GetWebstoreItemDetailURLPrefix() + extension_->id());
+ GURL store_url(extension_urls::GetWebstoreItemDetailURLPrefix() +
+ prompt_->extension()->id());
BrowserList::GetLastActiveWithProfile(profile_)->OpenURL(OpenURLParams(
store_url, Referrer(), NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK,
false));
@@ -153,7 +149,7 @@ void AppendRatingStarsShim(const SkBitmap* skiaImage, void* data) {
// Set control labels.
[titleField_ setStringValue:base::SysUTF16ToNSString(
Robert Sesek 2012/02/23 20:12:32 Can you re-wrap this line?
jstritar 2012/02/24 18:21:46 Done.
- prompt_->GetHeading(extension_->name()))];
+ prompt_->GetHeading())];
[okButton_ setTitle:base::SysUTF16ToNSString(
prompt_->GetAcceptButtonLabel())];
[cancelButton_ setTitle:prompt_->HasAbortButtonLabel() ?
@@ -167,7 +163,7 @@ void AppendRatingStarsShim(const SkBitmap* skiaImage, void* data) {
prompt_->GetUserCount())];
}
- NSImage* image = gfx::SkBitmapToNSImage(icon_);
+ NSImage* image = gfx::SkBitmapToNSImage(prompt_->icon());
[iconView_ setImage:image];
// Resize |titleField_| to fit the title.
@@ -198,7 +194,7 @@ void AppendRatingStarsShim(const SkBitmap* skiaImage, void* data) {
// If there are any warnings, then we have to do some special layout.
if (prompt_->GetPermissionCount() > 0) {
[subtitleField_ setStringValue:base::SysUTF16ToNSString(
- prompt_->GetPermissionsHeader())];
+ prompt_->GetPermissionsHeading())];
// We display the permission warnings as a simple text string, separated by
// newlines.
@@ -295,8 +291,6 @@ void AppendRatingStarsShim(const SkBitmap* skiaImage, void* data) {
void ShowExtensionInstallDialogImpl(
Profile* profile,
ExtensionInstallUI::Delegate* delegate,
- const Extension* extension,
- SkBitmap* icon,
const ExtensionInstallUI::Prompt& prompt) {
Browser* browser = BrowserList::GetLastActiveWithProfile(profile);
if (!browser) {
@@ -316,9 +310,7 @@ void ShowExtensionInstallDialogImpl(
[[ExtensionInstallDialogController alloc]
initWithParentWindow:native_window
profile:profile
- extension:extension
delegate:delegate
- icon:icon
prompt:prompt];
// TODO(mihaip): Switch this to be tab-modal (http://crbug.com/95455)

Powered by Google App Engine
This is Rietveld 408576698