Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Unified Diff: runtime/vm/intermediate_language.h

Issue 9455054: Incorporate some review comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index edd92bbaf56d7c49a322af6d263ebc57f23178df..8a40a22ac546b44290e17825b72ae027ab954287 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -212,6 +212,8 @@ FOR_EACH_INSTRUCTION(INSTRUCTION_TYPE_CHECK)
private:
bool mark_;
+
+ DISALLOW_COPY_AND_ASSIGN(Instruction);
};
@@ -236,6 +238,8 @@ class BlockEntryInstr : public Instruction {
private:
intptr_t block_number_;
+
+ DISALLOW_COPY_AND_ASSIGN(BlockEntryInstr);
};
@@ -254,12 +258,14 @@ class JoinEntryInstr : public BlockEntryInstr {
private:
Instruction* successor_;
+
+ DISALLOW_COPY_AND_ASSIGN(JoinEntryInstr);
};
class TargetEntryInstr : public BlockEntryInstr {
public:
- TargetEntryInstr() : BlockEntryInstr(), block_number_(-1), successor_(NULL) {
+ TargetEntryInstr() : BlockEntryInstr(), successor_(NULL) {
}
DECLARE_INSTRUCTION(TargetEntry)
@@ -272,8 +278,9 @@ class TargetEntryInstr : public BlockEntryInstr {
virtual void Postorder(GrowableArray<BlockEntryInstr*>* block_entries);
private:
- intptr_t block_number_;
Instruction* successor_;
+
+ DISALLOW_COPY_AND_ASSIGN(TargetEntryInstr);
};
@@ -296,6 +303,8 @@ class DoInstr : public Instruction {
private:
Computation* computation_;
Instruction* successor_;
+
+ DISALLOW_COPY_AND_ASSIGN(DoInstr);
};
@@ -323,6 +332,8 @@ class BindInstr : public Instruction {
const intptr_t temp_index_;
Computation* computation_;
Instruction* successor_;
+
+ DISALLOW_COPY_AND_ASSIGN(BindInstr);
};
@@ -340,6 +351,8 @@ class ReturnInstr : public Instruction {
private:
Value* value_;
+
+ DISALLOW_COPY_AND_ASSIGN(ReturnInstr);
};
@@ -368,6 +381,8 @@ class BranchInstr : public Instruction {
Value* value_;
TargetEntryInstr* true_successor_;
TargetEntryInstr* false_successor_;
+
+ DISALLOW_COPY_AND_ASSIGN(BranchInstr);
};
#undef DECLARE_INSTRUCTION
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698