Issue 9455011: Lazy removal of dead HValues in GVN from use lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9455011: Lazy removal of dead HValues in GVN from use lists. (Closed)

Created:
8 years, 10 months ago by Yang

Modified:
8 years, 10 months ago

Reviewers:
fschneider, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Lazy removal of dead HValues in GVN from use lists. BUG=v8:1969 TEST=regress/regress-1969 Committed: https://code.google.com/p/v8/source/detail?r=10812

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5061 lines, -3 lines)			Patch
M	src/hydrogen-instructions.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	2 chunks	+13 lines, -1 line	1 comment	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-1969.js	View	1 chunk	+5042 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM http://codereview.chromium.org/9455011/diff/1/test/mjsunit/regress/regress-1969.js File test/mjsunit/regress/regress-1969.js (right): http://codereview.chromium.org/9455011/diff/1/test/mjsunit/regress/regress-1969.js#newcode1 test/mjsunit/regress/regress-1969.js:1: // Copyright 2008 the V8 project authors. All ...

8 years, 10 months ago (2012-02-23 13:58:32 UTC) #2

fschneider

8 years, 10 months ago (2012-02-23 14:01:14 UTC) #3

drive-by:

http://codereview.chromium.org/9455011/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

http://codereview.chromium.org/9455011/diff/1/src/hydrogen-instructions.cc#ne...
src/hydrogen-instructions.cc:407: void HValue::ClearOperands() {
Could you get rid of all uses of ClearOperands?

Expand Messages | Collapse Messages