Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 945333002: Implement <webview> droplink event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bpe
Patch Set: Addressed Istiaque's comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_embedder.cc
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc
index 826167f2d33b2de6ea9a2a8b3dceadd7b46392d0..99a8fde739072e0408b41814abea52829302cce4 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder.cc
+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc
@@ -33,8 +33,9 @@ BrowserPluginEmbedder* BrowserPluginEmbedder::Create(
return new BrowserPluginEmbedder(web_contents);
}
-void BrowserPluginEmbedder::DragEnteredGuest(BrowserPluginGuest* guest) {
+bool BrowserPluginEmbedder::DragEnteredGuest(BrowserPluginGuest* guest) {
guest_dragging_over_ = guest->AsWeakPtr();
+ return guest_started_drag_.get() == guest;
}
void BrowserPluginEmbedder::DragLeftGuest(BrowserPluginGuest* guest) {
@@ -125,7 +126,7 @@ void BrowserPluginEmbedder::SystemDragEnded() {
}
void BrowserPluginEmbedder::OnUpdateDragCursor(bool* handled) {
- *handled = (guest_dragging_over_.get() != NULL);
+ *handled = !!guest_dragging_over_;
}
void BrowserPluginEmbedder::OnAttach(
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_embedder.h ('k') | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698