Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: chrome/browser/sync/engine/download_updates_command.h

Issue 9453036: [Sync] Remove --create-mobile-bookmarks-folder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync to head Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/sync/engine/DEPS ('k') | chrome/browser/sync/engine/download_updates_command.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_ENGINE_DOWNLOAD_UPDATES_COMMAND_H_ 5 #ifndef CHROME_BROWSER_SYNC_ENGINE_DOWNLOAD_UPDATES_COMMAND_H_
6 #define CHROME_BROWSER_SYNC_ENGINE_DOWNLOAD_UPDATES_COMMAND_H_ 6 #define CHROME_BROWSER_SYNC_ENGINE_DOWNLOAD_UPDATES_COMMAND_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 22 matching lines...) Expand all
33 // session can be found in the Syncer logic. When looping, the 33 // session can be found in the Syncer logic. When looping, the
34 // DownloadUpdatesCommand consumes the information stored by the 34 // DownloadUpdatesCommand consumes the information stored by the
35 // StoreTimestampsCommand. 35 // StoreTimestampsCommand.
36 // 36 //
37 // In practice, DownloadUpdatesCommand should loop until all updates are 37 // In practice, DownloadUpdatesCommand should loop until all updates are
38 // downloaded for all enabled datatypes (i.e., until the server indicates 38 // downloaded for all enabled datatypes (i.e., until the server indicates
39 // changes_remaining == 0 in the GetUpdates response), or until an error 39 // changes_remaining == 0 in the GetUpdates response), or until an error
40 // is encountered. 40 // is encountered.
41 class DownloadUpdatesCommand : public SyncerCommand { 41 class DownloadUpdatesCommand : public SyncerCommand {
42 public: 42 public:
43 DownloadUpdatesCommand(); 43 // |create_mobile_bookmarks_folder| controls whether or not to
44 // create the mobile bookmarks folder if it's not already created.
45 // Should be set to true only by mobile clients.
46 explicit DownloadUpdatesCommand(bool create_mobile_bookmarks_folder);
44 virtual ~DownloadUpdatesCommand(); 47 virtual ~DownloadUpdatesCommand();
45 48
46 // SyncerCommand implementation. 49 // SyncerCommand implementation.
47 virtual SyncerError ExecuteImpl(sessions::SyncSession* session) OVERRIDE; 50 virtual SyncerError ExecuteImpl(sessions::SyncSession* session) OVERRIDE;
48 51
49 private: 52 private:
50 FRIEND_TEST_ALL_PREFIXES(DownloadUpdatesCommandTest, VerifyAppendDebugInfo); 53 FRIEND_TEST_ALL_PREFIXES(DownloadUpdatesCommandTest, VerifyAppendDebugInfo);
51 void AppendClientDebugInfoIfNeeded(sessions::SyncSession* session, 54 void AppendClientDebugInfoIfNeeded(sessions::SyncSession* session,
52 sync_pb::DebugInfo* debug_info); 55 sync_pb::DebugInfo* debug_info);
56
57 const bool create_mobile_bookmarks_folder_;
58
53 DISALLOW_COPY_AND_ASSIGN(DownloadUpdatesCommand); 59 DISALLOW_COPY_AND_ASSIGN(DownloadUpdatesCommand);
54 }; 60 };
55 61
56 } // namespace browser_sync 62 } // namespace browser_sync
57 63
58 #endif // CHROME_BROWSER_SYNC_ENGINE_DOWNLOAD_UPDATES_COMMAND_H_ 64 #endif // CHROME_BROWSER_SYNC_ENGINE_DOWNLOAD_UPDATES_COMMAND_H_
59 65
OLDNEW
« no previous file with comments | « chrome/browser/sync/engine/DEPS ('k') | chrome/browser/sync/engine/download_updates_command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698