Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 9453028: Fix ExpiredCertAndGoBackTests (Closed)
Patch Set: Remove old comment Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/time.h" 6 #include "base/time.h"
7 #include "chrome/app/chrome_command_ids.h" 7 #include "chrome/app/chrome_command_ids.h"
8 #include "chrome/browser/tabs/tab_strip_model.h" 8 #include "chrome/browser/tabs/tab_strip_model.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_navigator.h" 10 #include "chrome/browser/ui/browser_navigator.h"
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 // We should be back to the original good page. 355 // We should be back to the original good page.
356 CheckAuthenticatedState(tab, false); 356 CheckAuthenticatedState(tab, false);
357 357
358 // Try to navigate to a new page. (to make sure bug 5800 is fixed). 358 // Try to navigate to a new page. (to make sure bug 5800 is fixed).
359 ui_test_utils::NavigateToURL(browser(), 359 ui_test_utils::NavigateToURL(browser(),
360 test_server()->GetURL("files/ssl/google.html")); 360 test_server()->GetURL("files/ssl/google.html"));
361 CheckUnauthenticatedState(tab); 361 CheckUnauthenticatedState(tab);
362 } 362 }
363 363
364 // Visits a page with https error and then goes back using Browser::GoBack. 364 // Visits a page with https error and then goes back using Browser::GoBack.
365 // See http://crbug.com/40932
366 IN_PROC_BROWSER_TEST_F(SSLUITest, 365 IN_PROC_BROWSER_TEST_F(SSLUITest,
367 DISABLED_TestHTTPSExpiredCertAndGoBackViaButton) { 366 TestHTTPSExpiredCertAndGoBackViaButton) {
368 ASSERT_TRUE(test_server()->Start()); 367 ASSERT_TRUE(test_server()->Start());
369 ASSERT_TRUE(https_server_expired_.Start()); 368 ASSERT_TRUE(https_server_expired_.Start());
370 369
371 // First navigate to an HTTP page. 370 // First navigate to an HTTP page.
372 ui_test_utils::NavigateToURL(browser(), 371 ui_test_utils::NavigateToURL(browser(),
373 test_server()->GetURL("files/ssl/google.html")); 372 test_server()->GetURL("files/ssl/google.html"));
374 WebContents* tab = browser()->GetSelectedWebContents(); 373 WebContents* tab = browser()->GetSelectedWebContents();
375 NavigationEntry* entry = tab->GetController().GetActiveEntry(); 374 NavigationEntry* entry = tab->GetController().GetActiveEntry();
376 ASSERT_TRUE(entry); 375 ASSERT_TRUE(entry);
377 376
(...skipping 14 matching lines...) Expand all
392 // the previous page. Prevents regression of http://crbug.com/82667. 391 // the previous page. Prevents regression of http://crbug.com/82667.
393 load_failed_observer.Wait(); 392 load_failed_observer.Wait();
394 EXPECT_FALSE(tab->GetRenderViewHost()->is_swapped_out()); 393 EXPECT_FALSE(tab->GetRenderViewHost()->is_swapped_out());
395 394
396 // We should be back at the original good page. 395 // We should be back at the original good page.
397 EXPECT_FALSE(browser()->GetSelectedWebContents()->GetInterstitialPage()); 396 EXPECT_FALSE(browser()->GetSelectedWebContents()->GetInterstitialPage());
398 CheckUnauthenticatedState(tab); 397 CheckUnauthenticatedState(tab);
399 } 398 }
400 399
401 // Visits a page with https error and then goes back using GoToOffset. 400 // Visits a page with https error and then goes back using GoToOffset.
402 // Disabled because its flaky: http://crbug.com/40932, http://crbug.com/43575. 401 // Disabled because its flaky: http://crbug.com/40932, http://crbug.com/43575.
wtc 2012/02/28 20:02:12 This comment should be deleted.
403 IN_PROC_BROWSER_TEST_F(SSLUITest, 402 IN_PROC_BROWSER_TEST_F(SSLUITest,
404 DISABLED_TestHTTPSExpiredCertAndGoBackViaMenu) { 403 TestHTTPSExpiredCertAndGoBackViaMenu) {
405 ASSERT_TRUE(test_server()->Start()); 404 ASSERT_TRUE(test_server()->Start());
406 ASSERT_TRUE(https_server_expired_.Start()); 405 ASSERT_TRUE(https_server_expired_.Start());
407 406
408 // First navigate to an HTTP page. 407 // First navigate to an HTTP page.
409 ui_test_utils::NavigateToURL(browser(), 408 ui_test_utils::NavigateToURL(browser(),
410 test_server()->GetURL("files/ssl/google.html")); 409 test_server()->GetURL("files/ssl/google.html"));
411 WebContents* tab = browser()->GetSelectedWebContents(); 410 WebContents* tab = browser()->GetSelectedWebContents();
412 NavigationEntry* entry = tab->GetController().GetActiveEntry(); 411 NavigationEntry* entry = tab->GetController().GetActiveEntry();
413 ASSERT_TRUE(entry); 412 ASSERT_TRUE(entry);
414 413
(...skipping 914 matching lines...) Expand 10 before | Expand all | Expand 10 after
1329 1328
1330 // Visit a page over https that contains a frame with a redirect. 1329 // Visit a page over https that contains a frame with a redirect.
1331 1330
1332 // XMLHttpRequest insecure content in synchronous mode. 1331 // XMLHttpRequest insecure content in synchronous mode.
1333 1332
1334 // XMLHttpRequest insecure content in asynchronous mode. 1333 // XMLHttpRequest insecure content in asynchronous mode.
1335 1334
1336 // XMLHttpRequest over bad ssl in synchronous mode. 1335 // XMLHttpRequest over bad ssl in synchronous mode.
1337 1336
1338 // XMLHttpRequest over OK ssl in synchronous mode. 1337 // XMLHttpRequest over OK ssl in synchronous mode.
OLDNEW
« no previous file with comments | « no previous file | content/browser/ssl/ssl_error_handler.cc » ('j') | content/browser/ssl/ssl_error_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698