Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: client/dom/generated/src/frog/HTMLIFrameElement.dart

Issue 9453004: Cross frame access tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Frog DOM support for safe cross-frame window access. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/dom/generated/src/frog/HTMLIFrameElement.dart
diff --git a/client/dom/generated/src/frog/HTMLIFrameElement.dart b/client/dom/generated/src/frog/HTMLIFrameElement.dart
index 13825e46822c015e5112cc03b442bbf6acca5bfb..8c26b4e86778b6670ecaa654cc982a24bb2a295b 100644
--- a/client/dom/generated/src/frog/HTMLIFrameElement.dart
+++ b/client/dom/generated/src/frog/HTMLIFrameElement.dart
@@ -1,12 +1,11 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
class _HTMLIFrameElementJs extends _HTMLElementJs implements HTMLIFrameElement native "*HTMLIFrameElement" {
String align;
- final _DocumentJs contentDocument;
-
- final _DOMWindowJs contentWindow;
-
String frameBorder;
String height;
@@ -28,4 +27,70 @@ class _HTMLIFrameElementJs extends _HTMLElementJs implements HTMLIFrameElement n
String width;
_SVGDocumentJs getSVGDocument() native;
+
+
+ Window get _contentWindow() native """
+ return this.contentWindow;
+ """;
+
+ // Override contentWindow to return secure wrapper.
+ Window get contentWindow() {
+ return _DOMWindowCrossFrameJs._createSafe(_contentWindow);
+ }
+}
+
+// TODO(vsm): Unify with Dartium version.
+class _DOMWindowCrossFrameJs implements DOMType, DOMWindow {
+ // Private window.
+ _DOMWindowJs _window;
+
+ // DOMType
+ var dartObjectLocalStorage;
+ String get typeName() => "DOMWindow";
+
+ // Fields.
+ // TODO(vsm): Wrap these two.
+ History get history() => _window.history;
+ Location get location() => _window.location;
+
+ bool get closed() => _window.closed;
+ int get length() => _window.length;
+ DOMWindow get opener() => _createDOMWindowCrossFrame(_window.opener);
+ DOMWindow get parent() => _createDOMWindowCrossFrame(_window.parent);
+ DOMWindow get top() => _createDOMWindowCrossFrame(_window.top);
+
+ // TODO(vsm): Why is this needed? How do I get a
+ // NoSuchMethodException.
+ var get document() { throw new Exception(); }
+
+ // Methods.
+ void focus() {
+ _window.focus();
+ }
+
+ void blur() {
+ _window.blur();
+ }
+
+ void close() {
+ _window.close();
+ }
+
+ void postMessage(Dynamic message, String targetOrigin, [List messagePorts = null]) {
+ if (messagePorts == null) {
+ _window.postMessage(message, targetOrigin);
+ } else {
+ _window.postMessage(message, targetOrigin, messagePorts);
+ }
+ }
+
+ // Implementation support.
+ _DOMWindowCrossFrameJs(this._window);
+
+ static DOMWindow _createSafe(w) {
+ // TODO(vsm): Check if it's the top-level window. Return unwrapped.
+
+ // TODO(vsm): Cache or implement equality.
+ return new _DOMWindowCrossFrameJs(w);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698