Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 9452025: Adding Milestone in chromium bug hunter output file and email. (Closed)

Created:
8 years, 10 months ago by imasaki1
Modified:
8 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, pam+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adding Milestone in chromium bug hunter output file and email. Also, fix some minor issues relating to empty status. BUG=115503 TEST= locally executed the scripts and made sure it is working as intended. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124468

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix the typo metioned in the CR comment. #

Patch Set 3 : change year in the header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M media/tools/bug_hunter/bug_hunter.py View 1 2 3 chunks +16 lines, -8 lines 0 comments Download
M media/tools/bug_hunter/bug_hunter_test.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/tools/bug_hunter/bug_hunter_unittest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
imasaki1
Thanks.
8 years, 10 months ago (2012-02-23 18:31:30 UTC) #1
DaleCurtis
LGTM, sorry I didn't see this until now. You'll still need a committer to LGTM ...
8 years, 10 months ago (2012-02-27 23:58:17 UTC) #2
imasaki1
Dennis, can you look at this one, too? Thanks.
8 years, 10 months ago (2012-02-28 00:41:59 UTC) #3
dennis_jeffrey
Just 1 typo to fix. https://chromiumcodereview.appspot.com/9452025/diff/1/media/tools/bug_hunter/bug_hunter.py File media/tools/bug_hunter/bug_hunter.py (right): https://chromiumcodereview.appspot.com/9452025/diff/1/media/tools/bug_hunter/bug_hunter.py#newcode260 media/tools/bug_hunter/bug_hunter.py:260: 'state': entry.state.text if entry.status ...
8 years, 10 months ago (2012-02-28 02:10:59 UTC) #4
imasaki1
Thanks. https://chromiumcodereview.appspot.com/9452025/diff/1/media/tools/bug_hunter/bug_hunter.py File media/tools/bug_hunter/bug_hunter.py (right): https://chromiumcodereview.appspot.com/9452025/diff/1/media/tools/bug_hunter/bug_hunter.py#newcode260 media/tools/bug_hunter/bug_hunter.py:260: 'state': entry.state.text if entry.status is not None else ...
8 years, 9 months ago (2012-02-29 00:04:21 UTC) #5
dennis_jeffrey
8 years, 9 months ago (2012-02-29 01:17:00 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698