test/cctest/test-heap.cc - Issue 9452002: Ensure that executable pages are properly guarded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 9452002: Ensure that executable pages are properly guarded. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap.cc

diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc

index a6dd83054b27a9f00f067d25cf45327133b859c8..f29d43e9dcb446f2df299db149fda322ce838837 100644

--- a/test/cctest/test-heap.cc

+++ b/test/cctest/test-heap.cc

@@ -820,7 +820,7 @@ TEST(Iteration) {

FACTORY->NewStringFromAscii(CStrVector("abcdefghij"), TENURED);

// Allocate a large string (for large object space).

- int large_size = HEAP->MaxObjectSizeInPagedSpace() + 1;

+ int large_size = Page::kMaxNonCodeHeapObjectSize + 1;

char* str = new char[large_size];

for (int i = 0; i < large_size - 1; ++i) str[i] = 'a';

str[large_size - 1] = '\0';