dart/frog/leg/native_emitter.dart - Issue 9447100: Return null from stringValue and call slowToString() instead of toString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/frog/leg/native_emitter.dart

Issue 9447100: Return null from stringValue and call slowToString() instead of toString(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: changes Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/frog/leg/native_emitter.dart

diff --git a/dart/frog/leg/native_emitter.dart b/dart/frog/leg/native_emitter.dart

index fba6185906da6dd99183be6c8aabec746b376e2a..b61581179eb88772b8480db92029bd3cff6e6a55 100644

--- a/dart/frog/leg/native_emitter.dart

+++ b/dart/frog/leg/native_emitter.dart

@@ -130,7 +130,7 @@ if (typeof $dynamicMetadataName == 'undefined') $dynamicMetadataName = [];''';

void generateNativeClass(ClassElement classElement, StringBuffer buffer) {

addDynamicFunctionIfNecessary(buffer);

assert(classElement.backendMembers.isEmpty());

- String nativeName = classElement.nativeName.stringValue;

+ String nativeName = classElement.nativeName.slowToString();

nativeName = nativeName.substring(2, nativeName.length - 1);

for (Element member in classElement.members) {

if (member.isInstanceMember()) {

« no previous file with comments | « dart/frog/leg/namer.dart ('k') | dart/frog/leg/native_handler.dart » ('j') | no next file with comments »