Issue 9447087: Revert 123635 - Implement timeouts for IQ requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9447087: Revert 123635 - Implement timeouts for IQ requests. (Closed)

Created:
8 years, 10 months ago by jamesr

Modified:
8 years, 10 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 123635 - Implement timeouts for IQ requests. Now the IqRequest class supports setting timeouts for each request, and JingleSession uses it to disconnect if no response is receive within 10 secons from a request. BUG=107925 Review URL: http://codereview.chromium.org/9452038 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123638

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -277 lines)			Patch
M	remoting/host/heartbeat_sender.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/heartbeat_sender.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	remoting/host/heartbeat_sender_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/host/register_support_host_request.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/register_support_host_request.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	remoting/host/register_support_host_request_unittest.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	remoting/jingle_glue/iq_sender.h	View	3 chunks	+3 lines, -16 lines	0 comments	Download
M	remoting/jingle_glue/iq_sender.cc	View	3 chunks	+8 lines, -52 lines	0 comments	Download
M	remoting/jingle_glue/iq_sender_unittest.cc	View	4 chunks	+22 lines, -81 lines	0 comments	Download
M	remoting/jingle_glue/jingle_info_request.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/jingle_glue/jingle_info_request.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	remoting/protocol/jingle_messages.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	remoting/protocol/jingle_messages.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	remoting/protocol/jingle_session.h	View	5 chunks	+10 lines, -14 lines	0 comments	Download
M	remoting/protocol/jingle_session.cc	View	9 chunks	+60 lines, -93 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages