ipc/ipc_logging.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_logging.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: compile (racing with incoming CLs) Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_logging.cc

diff --git a/ipc/ipc_logging.cc b/ipc/ipc_logging.cc

index d50766c875c102c76dc7f1a265dfb0622281b22a..b9ca828be122c341c2e2db31f6572bbe76e08317 100644

--- a/ipc/ipc_logging.cc

+++ b/ipc/ipc_logging.cc

@@ -109,7 +109,7 @@ void Logging::SetIPCSender(IPC::Message::Sender* sender) {

void Logging::OnReceivedLoggingMessage(const Message& message) {

std::vector<LogData> data;

- void* iter = NULL;

+ PickleIterator iter(message);

if (!ReadParam(&message, &iter, &data))

return;

« no previous file with comments | « ipc/ipc_fuzzing_tests.cc ('k') | ipc/ipc_message.h » ('j') | no next file with comments »