ipc/ipc_channel_posix.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_posix.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: compile (racing with incoming CLs) Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_channel_posix.cc

diff --git a/ipc/ipc_channel_posix.cc b/ipc/ipc_channel_posix.cc

index 1960cb037e0c4f927b10196b5f5373ee1bdfd77a..4d6b8a024f04951d1e6ed81bb9c5ff902ddfe0ea 100644

--- a/ipc/ipc_channel_posix.cc

+++ b/ipc/ipc_channel_posix.cc

@@ -1126,7 +1126,7 @@ void Channel::ChannelImpl::ClearInputFDs() {

void Channel::ChannelImpl::HandleHelloMessage(const Message& msg) {

// The Hello message contains only the process id.

- void *iter = NULL;

+ PickleIterator iter(msg);

int pid;

if (!msg.ReadInt(&iter, &pid))

NOTREACHED();

« no previous file with comments | « gpu/ipc/gpu_command_buffer_traits.cc ('k') | ipc/ipc_fuzzing_tests.cc » ('j') | no next file with comments »