chrome/common/content_settings_pattern.h - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/content_settings_pattern.h

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: compile (racing with incoming CLs) Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/content_settings_pattern.h

diff --git a/chrome/common/content_settings_pattern.h b/chrome/common/content_settings_pattern.h

index d670b78760c3e489af40cfe160cb93da45ec6f55..858d210cc2fa6551aa133049cab41b386035be00 100644

--- a/chrome/common/content_settings_pattern.h

+++ b/chrome/common/content_settings_pattern.h

@@ -16,6 +16,8 @@

#include "base/gtest_prod_util.h"

class GURL;

+class Pickle;

+class PickleIterator;

namespace content_settings {

class PatternParser;

@@ -167,7 +169,7 @@ class ContentSettingsPattern {

// Serializes the pattern to an IPC message or deserializes it.

void WriteToMessage(IPC::Message* m) const;

- bool ReadFromMessage(const IPC::Message* m, void** iter);

+ bool ReadFromMessage(const IPC::Message* m, PickleIterator* iter);

// True if this is a valid pattern.

bool IsValid() const { return is_valid_; }