Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7383)

Unified Diff: chrome/browser/sessions/compress_data_helper_unittest.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile (racing with incoming CLs) Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/compress_data_helper.cc ('k') | chrome/browser/sessions/session_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/compress_data_helper_unittest.cc
diff --git a/chrome/browser/sessions/compress_data_helper_unittest.cc b/chrome/browser/sessions/compress_data_helper_unittest.cc
index 3e1da3f0213717fc6dd8b4d9406266d1b9770aba..f993bc5cb532d1b25675ec9ed23d2ab670afc701 100644
--- a/chrome/browser/sessions/compress_data_helper_unittest.cc
+++ b/chrome/browser/sessions/compress_data_helper_unittest.cc
@@ -23,7 +23,7 @@ TEST_F(CompressDataHelperTest, CompressAndDecompressData) {
EXPECT_GT(bytes_written, 0);
EXPECT_LT(bytes_written, max_bytes + 1);
- void* it = NULL;
+ PickleIterator it(pickle);
std::string data_out;
ASSERT_TRUE(CompressDataHelper::ReadAndDecompressStringFromPickle(
@@ -45,7 +45,7 @@ TEST_F(CompressDataHelperTest, CompressAndDecompressEmptyData) {
EXPECT_EQ(0, bytes_written);
- void* it = NULL;
+ PickleIterator it(pickle);
std::string data_out;
ASSERT_TRUE(CompressDataHelper::ReadAndDecompressStringFromPickle(
pickle, &it, &data_out));
@@ -65,7 +65,7 @@ TEST_F(CompressDataHelperTest, TooMuchData) {
EXPECT_EQ(0, bytes_written);
// When the data is read, we get an empty string back.
- void* it = NULL;
+ PickleIterator it(pickle);
std::string data_out;
ASSERT_TRUE(CompressDataHelper::ReadAndDecompressStringFromPickle(
pickle, &it, &data_out));
« no previous file with comments | « chrome/browser/sessions/compress_data_helper.cc ('k') | chrome/browser/sessions/session_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698