chrome/browser/automation/url_request_automation_job.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/url_request_automation_job.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: compile (racing with incoming CLs) Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/automation/url_request_automation_job.cc

diff --git a/chrome/browser/automation/url_request_automation_job.cc b/chrome/browser/automation/url_request_automation_job.cc

index c5b3d70a0518743ac433721aa60cd3ea7fa9738f..231a4c558f7a596219b6e5235c4728a8377f274c 100644

--- a/chrome/browser/automation/url_request_automation_job.cc

+++ b/chrome/browser/automation/url_request_automation_job.cc

@@ -253,7 +253,7 @@ bool URLRequestAutomationJob::MayFilterMessage(const IPC::Message& message,

case AutomationMsg_RequestStarted::ID:

case AutomationMsg_RequestData::ID:

case AutomationMsg_RequestEnd::ID: {

- void* iter = NULL;

+ PickleIterator iter(message);

if (message.ReadInt(&iter, request_id))

return true;

break;

« no previous file with comments | « base/pickle_unittest.cc ('k') | chrome/browser/bookmarks/bookmark_node_data.h » ('j') | no next file with comments »