webkit/glue/webcursor_win.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/webcursor_win.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/glue/webcursor_win.cc

diff --git a/webkit/glue/webcursor_win.cc b/webkit/glue/webcursor_win.cc

index 4d8e520f11113c7be2f0e5a2c266a3746d5ae3cf..785bc031120ff7c7ece9b76b36ddfa14c0fe93db 100644

--- a/webkit/glue/webcursor_win.cc

+++ b/webkit/glue/webcursor_win.cc

@@ -216,8 +216,8 @@ bool WebCursor::SerializePlatformData(Pickle* pickle) const {

return pickle->WriteUInt32(reinterpret_cast<uint32>(external_cursor_));

}

-bool WebCursor::DeserializePlatformData(const Pickle* pickle, void** iter) {

- return pickle->ReadUInt32(iter, reinterpret_cast<uint32*>(&external_cursor_));

+bool WebCursor::DeserializePlatformData(PickleReader* iter) {

+ return iter->ReadUInt32(reinterpret_cast<uint32*>(&external_cursor_));

}

bool WebCursor::IsPlatformDataEqual(const WebCursor& other) const {