webkit/fileapi/file_system_usage_cache.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/file_system_usage_cache.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/fileapi/file_system_usage_cache.cc

diff --git a/webkit/fileapi/file_system_usage_cache.cc b/webkit/fileapi/file_system_usage_cache.cc

index 46bbdff669eeaafbf46c923c51503058becc57c2..75b43ee4069747a14ab9e823ee728a3e577c3c6f 100644

--- a/webkit/fileapi/file_system_usage_cache.cc

+++ b/webkit/fileapi/file_system_usage_cache.cc

@@ -131,7 +131,7 @@ int64 FileSystemUsageCache::Read(const FilePath& usage_file_path,

file_util::ReadFile(usage_file_path, buffer, kUsageFileSize))

return -1;

Pickle read_pickle(buffer, kUsageFileSize);

- void* iter = NULL;

+ PickleReader iter(read_pickle);

int64 fs_usage;

if (!read_pickle.ReadBytes(&iter, &header, kUsageFileHeaderSize) ||