ui/base/dragdrop/gtk_dnd_util.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/dragdrop/gtk_dnd_util.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/dragdrop/gtk_dnd_util.cc

diff --git a/ui/base/dragdrop/gtk_dnd_util.cc b/ui/base/dragdrop/gtk_dnd_util.cc

index d70aac8156d40c666aa3d1a4e9e3e9335f22b32e..48caef9fb1c567aa727a102f0206d7989ef21f9f 100644

--- a/ui/base/dragdrop/gtk_dnd_util.cc

+++ b/ui/base/dragdrop/gtk_dnd_util.cc

@@ -216,7 +216,7 @@ bool ExtractNamedURL(GtkSelectionData* selection_data,

reinterpret_cast<const char*>(

gtk_selection_data_get_data(selection_data)),

gtk_selection_data_get_length(selection_data));

- void* iter = NULL;

+ PickleReader iter(data);

std::string title_utf8, url_utf8;

if (!data.ReadString(&iter, &title_utf8) ||

!data.ReadString(&iter, &url_utf8)) {