net/base/x509_certificate_unittest.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/x509_certificate_unittest.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/x509_certificate_unittest.cc

diff --git a/net/base/x509_certificate_unittest.cc b/net/base/x509_certificate_unittest.cc

index 2968c0ad8d617777cc78a963d61e1ef44338fb0a..872212ed0c0e6452e65053bb5155130a3be92ecb 100644

--- a/net/base/x509_certificate_unittest.cc

+++ b/net/base/x509_certificate_unittest.cc

@@ -1043,7 +1043,7 @@ TEST(X509CertificateTest, Pickle) {

Pickle pickle;

cert->Persist(&pickle);

- void* iter = NULL;

+ PickleReader iter(pickle);

scoped_refptr<X509Certificate> cert_from_pickle =

X509Certificate::CreateFromPickle(

pickle, &iter, X509Certificate::PICKLETYPE_CERTIFICATE_CHAIN);