Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: content/common/child_process_sandbox_support_impl_linux.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jar feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/child_process_sandbox_support_impl_linux.cc
diff --git a/content/common/child_process_sandbox_support_impl_linux.cc b/content/common/child_process_sandbox_support_impl_linux.cc
index 9040cd055c904b2a180fab4e2521df89f29b691b..4ce8eaa33a48c50c2c98052146728a21b4c00df4 100644
--- a/content/common/child_process_sandbox_support_impl_linux.cc
+++ b/content/common/child_process_sandbox_support_impl_linux.cc
@@ -36,7 +36,7 @@ void GetFontFamilyForCharacters(const uint16_t* utf16,
bool isItalic = false;
if (n != -1) {
Pickle reply(reinterpret_cast<char*>(buf), n);
- void* pickle_iter = NULL;
+ PickleReader pickle_iter(reply);
if (reply.ReadString(&pickle_iter, &family_name) &&
reply.ReadBool(&pickle_iter, &isBold) &&
reply.ReadBool(&pickle_iter, &isItalic)) {
@@ -64,7 +64,7 @@ void GetRenderStyleForStrike(const char* family, int sizeAndStyle,
}
Pickle reply(reinterpret_cast<char*>(buf), n);
- void* pickle_iter = NULL;
+ PickleReader pickle_iter(reply);
int useBitmaps, useAutoHint, useHinting, hintStyle, useAntiAlias, useSubpixel;
if (reply.ReadInt(&pickle_iter, &useBitmaps) &&
reply.ReadInt(&pickle_iter, &useAutoHint) &&

Powered by Google App Engine
This is Rietveld 408576698