chrome/common/extensions/user_script_unittest.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/user_script_unittest.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/user_script_unittest.cc

diff --git a/chrome/common/extensions/user_script_unittest.cc b/chrome/common/extensions/user_script_unittest.cc

index 1afe6abf44faa47a5c5beac058239d879a1f3cfb..eb6cb32106aa94716c74e1f8757348b4bad7ffbb 100644

--- a/chrome/common/extensions/user_script_unittest.cc

+++ b/chrome/common/extensions/user_script_unittest.cc

@@ -189,7 +189,7 @@ TEST(ExtensionUserScriptTest, Pickle) {

Pickle pickle;

script1.Pickle(&pickle);

- void* iter = NULL;

+ PickleReader iter(pickle);

UserScript script2;

script2.Unpickle(pickle, &iter);