chrome/common/extensions/extension_unpacker.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_unpacker.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_unpacker.cc

diff --git a/chrome/common/extensions/extension_unpacker.cc b/chrome/common/extensions/extension_unpacker.cc

index aded6974c07f008ae58819b4808a0569dd0ddf41..6471fa66a0e52aeee3f618b947a6a251cc9e3d9f 100644

--- a/chrome/common/extensions/extension_unpacker.cc

+++ b/chrome/common/extensions/extension_unpacker.cc

@@ -252,7 +252,7 @@ bool ExtensionUnpacker::ReadImagesFromFile(const FilePath& extension_path,

return false;

IPC::Message pickle(file_str.data(), file_str.size());

- void* iter = NULL;

+ PickleReader iter(pickle);

return IPC::ReadParam(&pickle, &iter, images);

}

@@ -266,7 +266,7 @@ bool ExtensionUnpacker::ReadMessageCatalogsFromFile(

return false;

IPC::Message pickle(file_str.data(), file_str.size());

- void* iter = NULL;

+ PickleReader iter(pickle);

return IPC::ReadParam(&pickle, &iter, catalogs);

}