chrome/common/content_settings_pattern.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/content_settings_pattern.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/content_settings_pattern.cc

diff --git a/chrome/common/content_settings_pattern.cc b/chrome/common/content_settings_pattern.cc

index 1eb0697406f54bda204c293dc19d9845ece4f421..01396712dc1009e52ce8b363deb8e8d7ec1e7e29 100644

--- a/chrome/common/content_settings_pattern.cc

+++ b/chrome/common/content_settings_pattern.cc

@@ -403,7 +403,7 @@ void ContentSettingsPattern::WriteToMessage(IPC::Message* m) const {

}

bool ContentSettingsPattern::ReadFromMessage(const IPC::Message* m,

- void** iter) {

+ PickleReader* iter) {

return IPC::ReadParam(m, iter, &is_valid_) &&

IPC::ReadParam(m, iter, &parts_);

}