Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6022)

Unified Diff: chrome/common/common_param_traits.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jar feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/common_param_traits.cc
diff --git a/chrome/common/common_param_traits.cc b/chrome/common/common_param_traits.cc
index 8a14b30ee36b0e9ea66e22b0ae3f3fcf983ffee6..54addd9952f35c8fd672fa9b08d385d929a88ff0 100644
--- a/chrome/common/common_param_traits.cc
+++ b/chrome/common/common_param_traits.cc
@@ -13,7 +13,7 @@ void ParamTraits<ContentSetting>::Write(Message* m, const param_type& p) {
m->WriteInt(static_cast<int>(p));
}
-bool ParamTraits<ContentSetting>::Read(const Message* m, void** iter,
+bool ParamTraits<ContentSetting>::Read(const Message* m, PickleReader* iter,
param_type* p) {
int type;
if (!m->ReadInt(iter, &type))
@@ -51,8 +51,9 @@ void ParamTraits<ContentSettingsType>::Write(Message* m, const param_type& p) {
m->WriteInt(static_cast<int>(p));
}
-bool ParamTraits<ContentSettingsType>::Read(const Message* m, void** iter,
- param_type* p) {
+bool ParamTraits<ContentSettingsType>::Read(const Message* m,
+ PickleReader* iter,
+ param_type* p) {
int type;
if (!m->ReadInt(iter, &type))
return false;

Powered by Google App Engine
This is Rietveld 408576698