chrome/browser/visitedlink/visitedlink_unittest.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/visitedlink/visitedlink_unittest.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/visitedlink/visitedlink_unittest.cc

diff --git a/chrome/browser/visitedlink/visitedlink_unittest.cc b/chrome/browser/visitedlink/visitedlink_unittest.cc

index f0b4f7ff25d3c5c5768ecb679890657d547bdcdb..24288fd5c7f6261b100b076c289550211702de53 100644

--- a/chrome/browser/visitedlink/visitedlink_unittest.cc

+++ b/chrome/browser/visitedlink/visitedlink_unittest.cc

@@ -526,7 +526,7 @@ class VisitRelayingRenderProcessHost : public MockRenderProcessHost {

Profile::FromBrowserContext(GetBrowserContext()));

if (msg->type() == ChromeViewMsg_VisitedLink_Add::ID) {

- void* iter = NULL;

+ PickleReader iter(*msg);

std::vector<uint64> fingerprints;

CHECK(IPC::ReadParam(msg, &iter, &fingerprints));

counting_profile->CountAddEvent(fingerprints.size());