Refactor Pickle Read methods to use higher performance PickleIterator.

base/file_path.h

Index: base/file_path.h
diff --git a/base/file_path.h b/base/file_path.h
index bde3cec30c21e53002408469446a3761b1717654..c5c71e4062aea8321621e4f913322a7e7c5c6c51 100644
--- a/base/file_path.h
+++ b/base/file_path.h
@@ -122,6 +122,7 @@
 #endif  // OS_WIN
 
 class Pickle;
+class PickleReader;
 
 // An abstraction to isolate users from the differences between native
 // pathnames on different platforms.
@@ -339,7 +340,7 @@ class BASE_EXPORT FilePath {
   static FilePath FromUTF8Unsafe(const std::string& utf8);
 
   void WriteToPickle(Pickle* pickle);
-  bool ReadFromPickle(Pickle* pickle, void** iter);
+  bool ReadFromPickle(PickleReader* iter);

[darin (slow to review), 2012/03/06 18:02:13]

sorry to nit pick, but it'd be great if you could rename the parameter to
'reader' instead of 'iter'... or maybe go with PickleIterator?

[jbates, 2012/03/06 22:16:38]

Done: changed to PickleIterator.

 
   // Normalize all path separators to backslash on Windows
   // (if FILE_PATH_USES_WIN_SEPARATORS is true), or do nothing on POSIX systems.