Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1661)

Unified Diff: webkit/glue/npruntime_util.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jar feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/npruntime_util.cc
diff --git a/webkit/glue/npruntime_util.cc b/webkit/glue/npruntime_util.cc
index a408770ee79e47e9adcd62b343352fdd6cd7e1e0..f6c06832db4358d547d9c2222d1b69ebd6c5cb47 100644
--- a/webkit/glue/npruntime_util.cc
+++ b/webkit/glue/npruntime_util.cc
@@ -26,22 +26,22 @@ bool SerializeNPIdentifier(NPIdentifier identifier, Pickle* pickle) {
return pickle->WriteInt(number);
}
-bool DeserializeNPIdentifier(const Pickle& pickle, void** pickle_iter,
+bool DeserializeNPIdentifier(PickleReader* pickle_iter,
NPIdentifier* identifier) {
bool is_string;
- if (!pickle.ReadBool(pickle_iter, &is_string))
+ if (!pickle_iter->ReadBool(&is_string))
return false;
if (is_string) {
const char* data;
int data_len;
- if (!pickle.ReadData(pickle_iter, &data, &data_len))
+ if (!pickle_iter->ReadData(&data, &data_len))
return false;
DCHECK_EQ((static_cast<size_t>(data_len)), strlen(data) + 1);
*identifier = WebBindings::getStringIdentifier(data);
} else {
int number;
- if (!pickle.ReadInt(pickle_iter, &number))
+ if (!pickle_iter->ReadInt(&number))
return false;
*identifier = WebBindings::getIntIdentifier(number);
}
« base/pickle.cc ('K') | « webkit/glue/npruntime_util.h ('k') | webkit/glue/webcursor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698