content/test/mock_render_thread.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/mock_render_thread.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/mock_render_thread.cc

diff --git a/content/test/mock_render_thread.cc b/content/test/mock_render_thread.cc

index 166353191b0b9b7be8ae0730bb39b5caa6de4d82..57ba55d7020b62563bcec983112b3bed2ccb2c89 100644

--- a/content/test/mock_render_thread.cc

+++ b/content/test/mock_render_thread.cc

@@ -24,7 +24,7 @@ void MockRenderThread::VerifyRunJavaScriptMessageSend(

const IPC::Message* alert_msg =

sink_.GetUniqueMessageMatching(ViewHostMsg_RunJavaScriptMessage::ID);

ASSERT_TRUE(alert_msg);

- void* iter = IPC::SyncMessage::GetDataIterator(alert_msg);

+ PickleReader iter = IPC::SyncMessage::GetDataIterator(alert_msg);

ViewHostMsg_RunJavaScriptMessage::SendParam alert_param;

ASSERT_TRUE(IPC::ReadParam(alert_msg, &iter, &alert_param));

EXPECT_EQ(expected_alert_message, alert_param.a);