Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: chrome/common/extensions/extension_messages.h

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jar feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_messages.h
diff --git a/chrome/common/extensions/extension_messages.h b/chrome/common/extensions/extension_messages.h
index c295985b2a4151c3c58c92cc39ee0c200da81731..76b7b2ed0c919acce53ff127787f8cb4cbc3eee6 100644
--- a/chrome/common/extensions/extension_messages.h
+++ b/chrome/common/extensions/extension_messages.h
@@ -128,7 +128,7 @@ template <>
struct ParamTraits<URLPattern> {
typedef URLPattern param_type;
static void Write(Message* m, const param_type& p);
- static bool Read(const Message* m, void** iter, param_type* p);
+ static bool Read(const Message* m, PickleReader* iter, param_type* p);
static void Log(const param_type& p, std::string* l);
};
@@ -136,7 +136,7 @@ template <>
struct ParamTraits<URLPatternSet> {
typedef URLPatternSet param_type;
static void Write(Message* m, const param_type& p);
- static bool Read(const Message* m, void** iter, param_type* p);
+ static bool Read(const Message* m, PickleReader* iter, param_type* p);
static void Log(const param_type& p, std::string* l);
};
@@ -144,7 +144,7 @@ template <>
struct ParamTraits<ExtensionAPIPermission::ID> {
typedef ExtensionAPIPermission::ID param_type;
static void Write(Message* m, const param_type& p);
- static bool Read(const Message* m, void** iter, param_type* p);
+ static bool Read(const Message* m, PickleReader* iter, param_type* p);
static void Log(const param_type& p, std::string* l);
};
@@ -152,7 +152,7 @@ template <>
struct ParamTraits<ExtensionMsg_Loaded_Params> {
typedef ExtensionMsg_Loaded_Params param_type;
static void Write(Message* m, const param_type& p);
- static bool Read(const Message* m, void** iter, param_type* p);
+ static bool Read(const Message* m, PickleReader* iter, param_type* p);
static void Log(const param_type& p, std::string* l);
};

Powered by Google App Engine
This is Rietveld 408576698