Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: base/metrics/histogram.h

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jar feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_path.cc ('k') | base/metrics/histogram.cc » ('j') | base/pickle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram.h
diff --git a/base/metrics/histogram.h b/base/metrics/histogram.h
index d203e54276b35dd9f10c449d2eb39edc7b136370..fecf858311c5bbbb6ad59dcc3785320ee824329c 100644
--- a/base/metrics/histogram.h
+++ b/base/metrics/histogram.h
@@ -54,6 +54,7 @@
#include "base/time.h"
class Pickle;
+class PickleReader;
namespace base {
@@ -404,7 +405,7 @@ class BASE_EXPORT Histogram {
void Subtract(const SampleSet& other);
bool Serialize(Pickle* pickle) const;
- bool Deserialize(void** iter, const Pickle& pickle);
+ bool Deserialize(PickleReader* iter);
protected:
// Actual histogram data is stored in buckets, showing the count of values
@@ -757,7 +758,7 @@ class BASE_EXPORT CustomHistogram : public Histogram {
// Helper for deserializing CustomHistograms. |*ranges| should already be
// correctly sized before this call. Return true on success.
- static bool DeserializeRanges(void** iter, const Pickle& pickle,
+ static bool DeserializeRanges(PickleReader* iter,
std::vector<Histogram::Sample>* ranges);
« no previous file with comments | « base/file_path.cc ('k') | base/metrics/histogram.cc » ('j') | base/pickle.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698