Refactor Pickle Read methods to use higher performance PickleIterator.

ppapi/proxy/serialized_var.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/serialized_var.h"
 
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "ipc/ipc_message_utils.h"
 #include "ppapi/proxy/dispatcher.h"
@@ skipping 129 matching lines @@
       m->WriteInt64(var_.value.as_id);
       break;
     case PP_VARTYPE_ARRAY:
     case PP_VARTYPE_DICTIONARY:
       // TODO(brettw) when these are supported, implement this.
       NOTIMPLEMENTED();
       break;
   }
 }
 
-bool SerializedVar::Inner::ReadFromMessage(const IPC::Message* m, void** iter) {
+bool SerializedVar::Inner::ReadFromMessage(const IPC::Message* m,
+                                           PickleIterator* iter) {
 #ifndef NDEBUG
   // We should only deserialize something once or will end up with leaked
   // references.
   //
   // One place this has happened in the past is using
   // std::vector<SerializedVar>.resize(). If you're doing this manually instead
   // of using the helper classes for handling in/out vectors of vars, be
   // sure you use the same pattern as the SerializedVarVector classes.
   DCHECK(!has_been_deserialized_);
   has_been_deserialized_ = true;
@@ skipping 353 matching lines @@
   inner_->ForceSetVarValueForTest(StringVar::StringToPPVar(str));
 }
 
 SerializedVarTestReader::SerializedVarTestReader(const SerializedVar& var)
     : SerializedVar(var) {
 }
 
 }  // namespace proxy
 }  // namespace ppapi