Refactor Pickle Read methods to use higher performance PickleIterator.

net/http/http_vary_data.h

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_VARY_DATA_H_
 #define NET_HTTP_HTTP_VARY_DATA_H_
 #pragma once
 
 #include "base/md5.h"
 #include "net/base/net_export.h"
 
 class Pickle;
+class PickleIterator;
 
 namespace net {
 
 struct HttpRequestInfo;
 class HttpResponseHeaders;
 
 // Used to implement the HTTP/1.1 Vary header.  This class contains a MD5 hash
 // over the request headers indicated by a Vary header.
 //
 // While RFC 2616 requires strict request header comparisons, it is much
@@ skipping 22 matching lines @@
   bool Init(const HttpRequestInfo& request_info,
             const HttpResponseHeaders& response_headers);
 
   // Initialize from a pickle that contains data generated by a call to the
   // vary data's Persist method.
   //
   // Upon success, true is returned and the object is marked as valid such that
   // is_valid() will return true.  Otherwise, false is returned to indicate
   // that this object is marked as invalid.
   //
-  bool InitFromPickle(const Pickle& pickle, void** pickle_iter);
+  bool InitFromPickle(const Pickle& pickle, PickleIterator* pickle_iter);
 
   // Call this method to persist the vary data. Illegal to call this on an
   // invalid object.
   void Persist(Pickle* pickle) const;
 
   // Call this method to test if the given request matches the previous request
   // with which this vary data corresponds.  The |cached_response_headers| must
   // be the same response headers used to generate this vary data.
   bool MatchesRequest(const HttpRequestInfo& request_info,
                       const HttpResponseHeaders& cached_response_headers) const;
@@ skipping 11 matching lines @@
   // A digested version of the request headers corresponding to the Vary header.
   base::MD5Digest request_digest_;
 
   // True when request_digest_ contains meaningful data.
   bool is_valid_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_VARY_DATA_H_