Refactor Pickle Read methods to use higher performance PickleIterator.

ipc/ipc_sync_message.h

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IPC_IPC_SYNC_MESSAGE_H_
 #define IPC_IPC_SYNC_MESSAGE_H_
 #pragma once
 
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
@@ skipping 42 matching lines @@
 
   base::WaitableEvent* pump_messages_event() const {
     return pump_messages_event_;
   }
 
   // Returns true if the message is a reply to the given request id.
   static bool IsMessageReplyTo(const Message& msg, int request_id);
 
   // Given a reply message, returns an iterator to the beginning of the data
   // (i.e. skips over the synchronous specific data).
-  static void* GetDataIterator(const Message* msg);
+  static PickleIterator GetDataIterator(const Message* msg);
 
   // Given a synchronous message (or its reply), returns its id.
   static int GetMessageId(const Message& msg);
 
   // Generates a reply message to the given message.
   static Message* GenerateReply(const Message* msg);
 
  private:
   struct SyncHeader {
     // unique ID (unique per sender)
     int message_id;
   };
 
   static bool ReadSyncHeader(const Message& msg, SyncHeader* header);
   static bool WriteSyncHeader(Message* msg, const SyncHeader& header);
 
   scoped_ptr<MessageReplyDeserializer> deserializer_;
   base::WaitableEvent* pump_messages_event_;
 };
 
 // Used to deserialize parameters from a reply to a synchronous message
 class IPC_EXPORT MessageReplyDeserializer {
  public:
   virtual ~MessageReplyDeserializer() {}
   bool SerializeOutputParameters(const Message& msg);
  private:
   // Derived classes need to implement this, using the given iterator (which
   // is skipped past the header for synchronous messages).
-  virtual bool SerializeOutputParameters(const Message& msg, void* iter) = 0;
+  virtual bool SerializeOutputParameters(const Message& msg,
+                                         PickleIterator iter) = 0;
 };
 
 // When sending a synchronous message, this structure contains an object
 // that knows how to deserialize the response.
 struct PendingSyncMsg {
   PendingSyncMsg(int id,
                  MessageReplyDeserializer* d,
                  base::WaitableEvent* e)
       : id(id), deserializer(d), done_event(e), send_result(false) { }
   int id;
   MessageReplyDeserializer* deserializer;
   base::WaitableEvent* done_event;
   bool send_result;
 };
 
 }  // namespace IPC
 
 #endif  // IPC_IPC_SYNC_MESSAGE_H_