Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: ipc/ipc_message_utils_impl.h

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile (racing with incoming CLs) Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | ipc/ipc_send_fds_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file contains templates forward declared (but not defined) in 5 // This file contains templates forward declared (but not defined) in
6 // ipc_message_utils.h so that they are only instantiated in certain files, 6 // ipc_message_utils.h so that they are only instantiated in certain files,
7 // notably a few IPC unit tests. 7 // notably a few IPC unit tests.
8 8
9 #ifndef IPC_IPC_MESSAGE_UTILS_IMPL_H_ 9 #ifndef IPC_IPC_MESSAGE_UTILS_IMPL_H_
10 #define IPC_IPC_MESSAGE_UTILS_IMPL_H_ 10 #define IPC_IPC_MESSAGE_UTILS_IMPL_H_
11 11
12 namespace IPC { 12 namespace IPC {
13 13
14 template <class ParamType> 14 template <class ParamType>
15 void MessageSchema<ParamType>::Write(Message* msg, const RefParam& p) { 15 void MessageSchema<ParamType>::Write(Message* msg, const RefParam& p) {
16 WriteParam(msg, p); 16 WriteParam(msg, p);
17 } 17 }
18 18
19 template <class ParamType> 19 template <class ParamType>
20 bool MessageSchema<ParamType>::Read(const Message* msg, Param* p) { 20 bool MessageSchema<ParamType>::Read(const Message* msg, Param* p) {
21 void* iter = NULL; 21 PickleIterator iter(*msg);
22 if (ReadParam(msg, &iter, p)) 22 if (ReadParam(msg, &iter, p))
23 return true; 23 return true;
24 NOTREACHED() << "Error deserializing message " << msg->type(); 24 NOTREACHED() << "Error deserializing message " << msg->type();
25 return false; 25 return false;
26 } 26 }
27 27
28 template <class SendParamType, class ReplyParamType> 28 template <class SendParamType, class ReplyParamType>
29 void SyncMessageSchema<SendParamType, ReplyParamType>::Write( 29 void SyncMessageSchema<SendParamType, ReplyParamType>::Write(
30 Message* msg, 30 Message* msg,
31 const RefSendParam& send) { 31 const RefSendParam& send) {
32 WriteParam(msg, send); 32 WriteParam(msg, send);
33 } 33 }
34 34
35 template <class SendParamType, class ReplyParamType> 35 template <class SendParamType, class ReplyParamType>
36 bool SyncMessageSchema<SendParamType, ReplyParamType>::ReadSendParam( 36 bool SyncMessageSchema<SendParamType, ReplyParamType>::ReadSendParam(
37 const Message* msg, SendParam* p) { 37 const Message* msg, SendParam* p) {
38 void* iter = SyncMessage::GetDataIterator(msg); 38 PickleIterator iter = SyncMessage::GetDataIterator(msg);
39 return ReadParam(msg, &iter, p); 39 return ReadParam(msg, &iter, p);
40 } 40 }
41 41
42 template <class SendParamType, class ReplyParamType> 42 template <class SendParamType, class ReplyParamType>
43 bool SyncMessageSchema<SendParamType, ReplyParamType>::ReadReplyParam( 43 bool SyncMessageSchema<SendParamType, ReplyParamType>::ReadReplyParam(
44 const Message* msg, typename TupleTypes<ReplyParam>::ValueTuple* p) { 44 const Message* msg, typename TupleTypes<ReplyParam>::ValueTuple* p) {
45 void* iter = SyncMessage::GetDataIterator(msg); 45 PickleIterator iter = SyncMessage::GetDataIterator(msg);
46 return ReadParam(msg, &iter, p); 46 return ReadParam(msg, &iter, p);
47 } 47 }
48 48
49 } // namespace IPC 49 } // namespace IPC
50 50
51 #endif // IPC_IPC_MESSAGE_UTILS_IMPL_H_ 51 #endif // IPC_IPC_MESSAGE_UTILS_IMPL_H_
OLDNEW
« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | ipc/ipc_send_fds_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698