Refactor Pickle Read methods to use higher performance PickleIterator.

chrome_frame/cfproxy_support.cc

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/cfproxy_private.h"
 
 #include <vector>
 #include "base/atomic_sequence_num.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/process_util.h"
@@ skipping 13 matching lines @@
       break;
     case AutomationMsg_ConnectExternalTab::ID:
       delegate->Completed_ConnectToTab(false, NULL, NULL, 0, 0);
       break;
   }
 }
 
 bool DispatchReplyOk(const IPC::Message* reply_msg, uint32 type,
                      ChromeProxyDelegate* delegate, SyncMessageContext* ctx,
                      TabsMap* tab2delegate) {
-  void* iter = IPC::SyncMessage::GetDataIterator(reply_msg);
+  PickleIterator iter = IPC::SyncMessage::GetDataIterator(reply_msg);
   switch (type) {
     case AutomationMsg_CreateExternalTab::ID: {
       // Tuple4<HWND, HWND, int, int> out;
       TupleTypes<AutomationMsg_CreateExternalTab::ReplyParam>::ValueTuple out;
       if (ReadParam(reply_msg, &iter, &out)) {
         DCHECK(tab2delegate->find(out.c) == tab2delegate->end());
         (*tab2delegate)[out.c] = delegate;
         delegate->Completed_CreateTab(true, out.a, out.b, out.c, out.d);
       }
       return true;
@@ skipping 257 matching lines @@
 
     command_line_string = command_line->GetCommandLineString();
     if (!extra_args.empty()) {
       command_line_string.append(L" ");
       command_line_string.append(extra_args);
     }
   }
 
   return command_line_string;
 }