Refactor Pickle Read methods to use higher performance PickleIterator.

chrome/test/automation/automation_proxy_uitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 739 matching lines @@
                          testing::EndsWith("favicon.ico")),
           testing::Field(&AutomationURLRequest::method, StrEq("GET")))))
       .Times(testing::AnyNumber())
       .WillRepeatedly(testing::WithArgs<0, 0>(testing::Invoke(
           CreateFunctor(this, &ExternalTabUITestMockClient::ReplyEnd,
                 net::URLRequestStatus(net::URLRequestStatus::FAILED, 0)))));
 }
 
 void ExternalTabUITestMockClient::InvalidateHandle(
     const IPC::Message& message) {
-  void* iter = NULL;
+  PickleIterator iter(message);
   int handle;
   ASSERT_TRUE(message.ReadInt(&iter, &handle));
 
   // Call base class
   AutomationProxy::InvalidateHandle(message);
   HandleClosed(handle);
 }
 
 // static
 ExternalTabSettings ExternalTabUITestMockClient::GetDefaultSettings() {
@@ skipping 810 matching lines @@
 
   std::string data;
   ASSERT_NO_FATAL_FAILURE(AssertReadPNG(snapshot_path_, &data));
   EXPECT_STREQ(kReferenceMd5, base::MD5String(data).c_str());
   if (CommandLine::ForCurrentProcess()->HasSwitch("dump-test-image")) {
     FilePath path(FILE_PATH_LITERAL("snapshot.png"));
     EXPECT_EQ(file_util::WriteFile(path, &data[0], data.length()),
               static_cast<int>(data.length()));
   }
 }