Refactor Pickle Read methods to use higher performance PickleIterator.

chrome/common/content_settings_pattern.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/content_settings_pattern.h"
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/string_split.h"
@@ skipping 385 matching lines @@
     : parts_(parts),
       is_valid_(valid) {
 }
 
 void ContentSettingsPattern::WriteToMessage(IPC::Message* m) const {
   IPC::WriteParam(m, is_valid_);
   IPC::WriteParam(m, parts_);
 }
 
 bool ContentSettingsPattern::ReadFromMessage(const IPC::Message* m,
-                                             void** iter) {
+                                             PickleIterator* iter) {
   return IPC::ReadParam(m, iter, &is_valid_) &&
          IPC::ReadParam(m, iter, &parts_);
 }
 
 bool ContentSettingsPattern::Matches(
     const GURL& url) const {
   // An invalid pattern matches nothing.
   if (!is_valid_)
     return false;
 
@@ skipping 218 matching lines @@
   if (!parts.is_port_wildcard && other_parts.is_port_wildcard)
     return ContentSettingsPattern::PREDECESSOR;
 
   int result = parts.port.compare(other_parts.port);
   if (result == 0)
     return ContentSettingsPattern::IDENTITY;
   if (result > 0)
     return ContentSettingsPattern::DISJOINT_ORDER_PRE;
   return ContentSettingsPattern::DISJOINT_ORDER_POST;
 }