Refactor Pickle Read methods to use higher performance PickleIterator.

chrome/browser/extensions/extension_messages_browsertest.cc

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_message_service.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/renderer/extensions/chrome_v8_context.h"
 #include "chrome/renderer/extensions/extension_dispatcher.h"
@@ skipping 46 matching lines @@
     "port.postMessage({message: 'content ready'});"
     "function doOnMessage(msg, port) {"
     "  alert('content got: ' + msg.val);"
     "}");
 
   // Verify that we opened a channel and sent a message through it.
   const IPC::Message* open_channel_msg =
       render_thread_->sink().GetUniqueMessageMatching(
           ExtensionHostMsg_OpenChannelToExtension::ID);
   ASSERT_TRUE(open_channel_msg);
-  void* iter = IPC::SyncMessage::GetDataIterator(open_channel_msg);
+  PickleIterator iter = IPC::SyncMessage::GetDataIterator(open_channel_msg);
   ExtensionHostMsg_OpenChannelToExtension::SendParam open_params;
   ASSERT_TRUE(IPC::ReadParam(open_channel_msg, &iter, &open_params));
   EXPECT_EQ("testName", open_params.d);
 
   const IPC::Message* post_msg =
       render_thread_->sink().GetUniqueMessageMatching(
           ExtensionHostMsg_PostMessage::ID);
   ASSERT_TRUE(post_msg);
   ExtensionHostMsg_PostMessage::Param post_params;
   ExtensionHostMsg_PostMessage::Read(post_msg, &post_params);
@@ skipping 60 matching lines @@
   render_thread_->VerifyRunJavaScriptMessageSend(ASCIIToUTF16("got: 42"));
 
   // Now simulate the channel closing.
   render_thread_->sink().ClearMessages();
   DispatchOnDisconnect(extension_dispatcher_->v8_context_set(), kPortId);
 
   // Verify that we got it.
   render_thread_->VerifyRunJavaScriptMessageSend(
       ASCIIToUTF16("disconnected: 24"));
 }