Refactor Pickle Read methods to use higher performance PickleIterator.

chrome/browser/extensions/extension_browser_actions_api.cc

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_browser_actions_api.h"
 
 #include <string>
 
 #include "base/values.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/common/chrome_notification_types.h"
@@ skipping 30 matching lines @@
       chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_UPDATED,
       content::Source<ExtensionAction>(browser_action_),
       content::NotificationService::NoDetails());
   return true;
 }
 
 bool BrowserActionSetIconFunction::RunBrowserAction() {
   base::BinaryValue* binary = NULL;
   EXTENSION_FUNCTION_VALIDATE(details_->GetBinary("imageData", &binary));
   IPC::Message bitmap_pickle(binary->GetBuffer(), binary->GetSize());
-  void* iter = NULL;
+  PickleIterator iter(bitmap_pickle);
   SkBitmap bitmap;
   EXTENSION_FUNCTION_VALIDATE(
       IPC::ReadParam(&bitmap_pickle, &iter, &bitmap));
   browser_action_->SetIcon(tab_id_, bitmap);
   return true;
 }
 
 bool BrowserActionSetTitleFunction::RunBrowserAction() {
   std::string title;
   EXTENSION_FUNCTION_VALIDATE(details_->GetString("title", &title));
@@ skipping 29 matching lines @@
   for (size_t i = 0; i < arraysize(color_array); ++i) {
     EXTENSION_FUNCTION_VALIDATE(list->GetInteger(i, &color_array[i]));
   }
 
   SkColor color = SkColorSetARGB(color_array[3], color_array[0], color_array[1],
                                  color_array[2]);
   browser_action_->SetBadgeBackgroundColor(tab_id_, color);
 
   return true;
 }